Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyro Integration #2503

Merged
merged 1,259 commits into from
Nov 3, 2024
Merged

Pyro Integration #2503

merged 1,259 commits into from
Nov 3, 2024

Conversation

ChecksumDev
Copy link
Contributor

Had to move this to a branch inside upstream for use internally, development will now proceed here.

@modrinth modrinth deleted a comment from MagmaBro123 Oct 10, 2024
he3als
he3als approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@he3als he3als left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm probably

@fangmarks
Copy link
Contributor

lgtm 2

Prospector
Prospector approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Prospector Prospector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thewander02
Copy link
Contributor

lgtm

@not-nullptr
Copy link
Contributor

i love you all lgtm

modrinth-bot
modrinth-bot approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@modrinth-bot modrinth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ferothefox and others added 6 commits November 2, 2024 20:39
@ferothefox
chore: switch to cdn links
80c0b8f 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: switch to cdn links
06a873f 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: switch to cdn links
23bd1aa 
Signed-off-by: Evan Song <theevansong@gmail.com>
@ferothefox
chore: switch to cdn links
f3420b8 
Signed-off-by: Evan Song <theevansong@gmail.com>
@Geometrically
Remove prod override
1bc6021
@Geometrically
Merge remote-tracking branch 'origin/pyro' into pyro
ebcdaa3
ferothefox
ferothefox approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@ferothefox ferothefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-nullptr
Copy link
Contributor

hi evan :)

@Geometrically Geometrically added this pull request to the merge queue Nov 3, 2024
@he3als
Copy link
Contributor

he3als commented Nov 3, 2024

waiting...

@izmystic
Copy link

izmystic commented Nov 3, 2024

🦑

@not-nullptr
Copy link
Contributor

maddie was here!!!!!

@Geometrically Geometrically removed this pull request from the merge queue due to a manual request Nov 3, 2024
@Geometrically Geometrically merged commit 185dd47 into main Nov 3, 2024
4 checks passed
@Geometrically Geometrically deleted the pyro branch November 3, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modrinth-bot modrinth-bot modrinth-bot approved these changes

@he3als he3als he3als approved these changes

@ferothefox ferothefox ferothefox approved these changes

@Geometrically Geometrically Geometrically approved these changes

@Prospector Prospector Prospector approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.